fix: dates inconsistent across site #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgoff
commented
Dec 10, 2024
| isCraftDate?: boolean; | ||
| } | ||
|
|
||
| export const makeDateString = ( |
There was a problem hiding this comment.
combination of existing makeDateString and useDateString
ericdrosas87
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the previous fix for dates to normalize timezones coming from Craft, some dates were inconsistent in different areas of the site.
There were multiple date utilities with duplicate code, and unclear pattern of use. To resolve this, the number of datestring utilities has been condensed down to two: one to generate strings and another to generate objects of parts.
Both utilities go through the same Craft date normalization by default.